Am I keeping a diary too long? Would it be better to spend the entire day at a certain time in the evening?

You can keep a diary for however long you like. I would journal at a specific time like before bed to clear your mind. It just really resonates with my personal needs, and I hope you find what resonates with yours as well.